Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] support diff editor #15

Closed
Cat1007 opened this issue May 4, 2023 · 3 comments · Fixed by #21
Closed

[feat] support diff editor #15

Cat1007 opened this issue May 4, 2023 · 3 comments · Fixed by #21

Comments

@Cat1007
Copy link
Contributor

Cat1007 commented May 4, 2023 •
edited
Loading

the useMonaco hook can be reuse
use https://microsoft.github.io/monaco-editor/docs.html#functions/editor.createDiffEditor.html to create diffEditor
@imguolao
Copy link
Owner

imguolao commented May 4, 2023 •
edited
Loading

No plan to support diff-editor, pr welcome.

@imguolao imguolao added the help wanted Extra attention is needed label May 8, 2023
@imguolao imguolao mentioned this issue Aug 22, 2023
Merged
imguolao added a commit that referenced this issue Aug 27, 2023
@imguolao
feat: support diff-editor (#21)
04593be 
fix #15
@Cat1007
Copy link
Contributor Author

Cat1007 commented Aug 27, 2023

nice 🎉🎉🎉🎉

@imguolao
Copy link
Owner

imguolao commented Aug 27, 2023 •
edited
Loading

There is still have a lot of work to be done.

  • update the diff editor's description in the README.md
  • test case of vue2.6
  • test case of vue2.7
  • npm publish
  • update website

@imguolao imguolao reopened this Aug 27, 2023
@imguolao imguolao removed the help wanted Extra attention is needed label Aug 27, 2023
This was referenced Aug 27, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support diff-editor imguolao/monaco-vue
2 participants
@imguolao @Cat1007