Fix problems with HQ2190_terr in namelist #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add '(terrestrial)' to name of scheme HQ2190_terr and '(terr)' to short name in namelist
florisvdh
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
Thanks for the explanation and solution! Code looks fine and I can reproduce exactly this result (clean git working directory).
However it seems that all HQ schemes in namelist have changed. This is caused by the appended space in case of paste("original name", ""). I'll merge and solve this in my branch with paste0().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used 2190 as attribute value for HQ2190_terr so we can join with the type names.
Then I made the name and shortname of HQ2190_terr more clear by adding 'terrstrial'/'terrestrisch' and 'terr' respectively.
I also defined the col_types when reading de googlesheet of MHQ types as I got a list instead of a character type for the
attribute_1collumn.