Simplification in specifying file locations #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refers to the (Zenodo) datasources for which it is recommended to store them in a standard location inside the
n2khab_datafolder.Please note, the simplifications introduced by this PR will break existing code in case a user deviated from the recommended default specified in vignette v020 (
vignette("v020_datastorage")), and explicitly usedpath/filearguments instead.Instead of two arguments
pathandfile, just one argumentfileis now used (with the exception ofread_GRTSmh_diffres(), wherepathandsubdirhave been replaced bydir).filetakes an absolute or relative path to the data source file. This solves #86.When R code did not use
path/filearguments (i.e., implementation of the default), it should continue to work as expected.