Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vue-tsc and update package-lock.json #1902

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

skryukov
Copy link
Contributor

@skryukov skryukov commented Jun 21, 2024

This PR updates vue-tsc to fix the Search string not found: "for (const existingRoot of buildInfoVersionMap.roots) {" error. Failed CI action can be found here: https://github.com/inertiajs/inertia/actions/runs/9617696317/job/26530006801.

I also noticed that the package-lock.json wasn't synced with the package.json (see CI logs). To prevent such errors, I have updated GitHub Actions to use npm ci, which fails under such circumstances. We can revert this change if it seems to be unnecessary.

I think we’d need to tweak how we cache node_modules first before we switch to this
@thecrypticace
Copy link
Contributor

thecrypticace commented Jun 24, 2024

I think we want to use npm ci but we'll need to change our node_modules caching strategy before we do that as it deletes the cached node_modules before installing so I've reverted that bit for now.

@thecrypticace thecrypticace changed the title Update vue-tsc, fix package-lock.json & use npm ci Bump vue-tsc and update package-lock.json Jun 24, 2024
@thecrypticace thecrypticace merged commit 6113a5e into inertiajs:master Jun 24, 2024
5 checks passed
@thecrypticace
Copy link
Contributor

Thanks! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants