Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add paging to find functions #237

Merged
merged 5 commits into from
May 5, 2021
Merged

feat: add paging to find functions #237

merged 5 commits into from
May 5, 2021

Conversation

russorat
Copy link
Contributor

@russorat russorat commented Apr 28, 2021

Closes #

Proposed Changes

adds the ability to page with the find_buckets function.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2021

Codecov Report

Merging #237 (96c993f) into master (f698030) will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files          25       25           
  Lines        2031     2031           
=======================================
  Hits         1866     1866           
  Misses        165      165           
Impacted Files Coverage Δ
influxdb_client/client/authorizations_api.py 86.36% <ø> (ø)
influxdb_client/client/tasks_api.py 92.39% <ø> (ø)
influxdb_client/client/organizations_api.py 84.21% <50.00%> (ø)
influxdb_client/client/bucket_api.py 93.75% <100.00%> (ø)
influxdb_client/client/labels_api.py 96.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f698030...96c993f. Read the comment docs.

@bednar bednar force-pushed the find-buckets-paging branch from 2f2cd22 to be45954 Compare April 29, 2021 10:29
@bednar bednar requested a review from rhajek April 29, 2021 10:30
@bednar
Copy link
Contributor

bednar commented Apr 29, 2021

Hi @russorat, I've change the find_buckets arguments to **kwargs. The **kwargs are better for cover future changes of server API.

@bednar bednar force-pushed the find-buckets-paging branch from be45954 to 11ae14c Compare April 30, 2021 06:47
@bednar bednar changed the title feat: add paging to find_buckets function feat: add paging to find functions May 5, 2021
@bednar bednar merged commit e26e7b0 into master May 5, 2021
@bednar bednar deleted the find-buckets-paging branch May 5, 2021 12:33
@bednar bednar added this to the 1.18.0 milestone May 5, 2021
@snape81
Copy link

snape81 commented Oct 12, 2023

Hi @russorat, I've change the find_buckets arguments to **kwargs. The **kwargs are better for cover future changes of server API.

return self._service.get_tasks(**kwargs).tasks

Yes but you dont pass back links section in response so ... how can we make the next page request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants