Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete_api also accept datetime as a value for start and stop #317

Merged
merged 3 commits into from
Aug 31, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Aug 20, 2021

Closes #313

Proposed Changes

The use can use datetime without timezone as a parameter for delete_api.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review August 20, 2021 10:21
@bednar bednar requested a review from rhajek August 20, 2021 10:21
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #317 (60ac161) into master (8539a9b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   92.52%   92.54%   +0.02%     
==========================================
  Files          27       27              
  Lines        2220     2226       +6     
==========================================
+ Hits         2054     2060       +6     
  Misses        166      166              
Impacted Files Coverage Δ
influxdb_client/client/delete_api.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8539a9b...60ac161. Read the comment docs.

@bednar bednar force-pushed the feat/delete-api-start-stop branch from e5fa4b4 to 60ac161 Compare August 31, 2021 09:33
@bednar bednar merged commit d2aa0af into master Aug 31, 2021
@bednar bednar deleted the feat/delete-api-start-stop branch August 31, 2021 09:42
@bednar bednar added this to the 1.21.0 milestone Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeleteApi.delete() shall accept date time object
3 participants