fix: fix DeprecationWarning in write API #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
=======================================
Coverage 92.74% 92.74%
=======================================
Files 31 31
Lines 2604 2604
=======================================
Hits 2415 2415
Misses 189 189
Continue to review full report at Codecov.
|
bednar
requested changes
Mar 15, 2022
There was a problem hiding this comment.
Thanks for your PR 👍. There are a few requirements that must be be satisfy before we accept the PR:
- Please satisfy our Checklist:
- Change
method_whitelisttoallowed_methodsalso in:tests/test_WriteOptions.pytests/test_WritesRetry.py
- Change minimal version of
urllib3insetup.pyto1.26.0(add a note about this change intoCHANGELOG.md)
Regards
Was getting this warning using the client with Python 3.9:
```
/lib/python3.9/site-packages/influxdb_client/client/write/retry.py:47: DeprecationWarning: Using 'method_whitelist' with Retry is deprecated and will be removed in v2.0. Use 'allowed_methods' instead
super().__init__(**kw)
```
This commit should fix things.
|
@bednar Should be good to go. Update the changelog, ran tests, and changed the tests, plus an updated setup.py. Let me know if you need anything else. |
bednar
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Was getting this warning using the client with Python 3.9:
This commit should fix things by moving to the new parameter name for
urllib3.Checklist
pytest testscompletes successfully