Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data_frame): add possibility to specify timestamp column #440

Merged
merged 5 commits into from
May 24, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented May 18, 2022

Closes #438

Proposed Changes

  • Specify column with timestamp
  • Use string column for timestamp
  • Specify timezone for timestamp

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #440 (8037c0c) into master (8543469) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   89.30%   89.35%   +0.04%     
==========================================
  Files          38       38              
  Lines        3245     3259      +14     
==========================================
+ Hits         2898     2912      +14     
  Misses        347      347              
Impacted Files Coverage Δ
influxdb_client/client/write_api.py 99.01% <ø> (ø)
influxdb_client/client/write_api_async.py 100.00% <ø> (ø)
...fluxdb_client/client/write/dataframe_serializer.py 98.26% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8543469...8037c0c. Read the comment docs.

@bednar bednar force-pushed the dataframe_ingesting branch from 224d745 to 8037c0c Compare May 24, 2022 09:10
@bednar bednar marked this pull request as ready for review May 24, 2022 09:10
@bednar bednar requested a review from rhajek May 24, 2022 09:10
@rhajek rhajek merged commit 2db3afc into master May 24, 2022
@rhajek rhajek deleted the dataframe_ingesting branch May 24, 2022 12:59
@bednar bednar added this to the 1.30.0 milestone May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: make working with pandas dataframe timestamps easier
3 participants