Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: formatting nanoseconds to Flux AST #457

Merged
merged 2 commits into from
Jun 14, 2022
Merged

fix: formatting nanoseconds to Flux AST #457

merged 2 commits into from
Jun 14, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jun 14, 2022

Closes #455

Proposed Changes

Fixed formatting datetime with nanoseconds to Flux AST.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2022

Codecov Report

Merging #457 (0897712) into master (22a8707) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   89.34%   89.35%           
=======================================
  Files          38       38           
  Lines        3258     3260    +2     
=======================================
+ Hits         2911     2913    +2     
  Misses        347      347           
Impacted Files Coverage Δ
influxdb_client/client/_base.py 97.84% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22a8707...0897712. Read the comment docs.

@bednar bednar marked this pull request as ready for review June 14, 2022 10:50
@bednar bednar requested a review from rhajek June 14, 2022 10:51
@bednar bednar added the bug Something isn't working label Jun 14, 2022
Copy link
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar merged commit 465476b into master Jun 14, 2022
@bednar bednar deleted the ast_nanoseconds branch June 14, 2022 11:43
@bednar bednar added this to the 1.30.0 milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nanoseconds lost when pd.Timestamp is used as a query parameter
3 participants