This repository was archived by the owner on Apr 24, 2023. It is now read-only.
Replace CRW datasync walkthrough with local setup #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmusil
changed the title
|
Why we have this:
|
wtrocki
requested review from
b1zzu,
craicoverflow,
damienomurchu,
jhellar,
nebelsprachen and
psturc
wtrocki
reviewed
Jul 28, 2020
|
|
||
| . In your project go to `./model/task.graphql` file. | ||
| This file contains GraphQL compatible schema | ||
| . Please add `@datasync` annotation to the model right bellow `@model` annotation |
There was a problem hiding this comment.
Suggested change
| . Please add `@datasync` annotation to the model right bellow `@model` annotation | |
| . Please add `@datasync` annotation to the model right bellow `@model` annotation. | |
| You can find more information about annotations in https://graphback.dev/docs/next/model/annotations |
wtrocki
approved these changes
Jul 28, 2020
|
We have changed only small amount of the instructions. I have verified all of those before (we have another PR with the more advanced state that will be merged later. What we want to do here is to merge the newest walkthrough that reflects what datasync team has with the most minimal and risky changes that simply work out of the box. |
Co-authored-by: Enda <ephelan@redhat.com>
wtrocki
approved these changes
Jul 28, 2020
|
@tonyxrmdavidson Are you happy for us to land this? I can confirm that this works end to end based on the tests. |
|
/lgtm |
|
@wtrocki Yeah, I think it looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Local setup walkthrough with Data Sync
walkthroughbranchCC @wtrocki