Add HEXL-FPGA compatibility for DyadicMultiply and KeySwitch #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an internal implementation for DyadicMultiply and KeySwitch and a CMake option HEXL_FPGA_COMPATIBILITY and compiler flag to disable the normal DyadicMultiply and KeySwitch and only leave the internal one available. This makes HEXL compatible with HEXL-FPGA. With this both libraries can use HEXL's header but HEXL-FPGA can override DyadicMultiply and KeySwitch with its own implementation while leaving the internal implementation as a fallback if the user desires to use the CPU implementation. Renamed all instances of CKKS in all functions and file names. Added a new root_of_unity_powers_ptr option to KeySwitch. This option will be used in HEXL-FPGA. Addressed the review comments Signed-off-by: Yan Meng <yan.meng@intel.com>
joserochh
approved these changes
Mar 10, 2022
jlhcrawford
reviewed
Mar 10, 2022
Signed-off-by: Yan Meng <yan.meng@intel.com>
Signed-off-by: Yan Meng <yan.meng@intel.com>
jlhcrawford
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an internal implementation for DyadicMultiply and KeySwitch and a CMake option HEXL_FPGA_COMPATIBILITY and compiler flag to disable the normal DyadicMultiply and KeySwitch and only leave the internal one available. This makes HEXL compatible with HEXL-FPGA. With this both libraries can use HEXL's header but HEXL-FPGA can override DyadicMultiply and KeySwitch with its own implementation while leaving the internal implementation as a fallback if the user desires to use the CPU implementation.
Renamed all instances of CKKS in all functions and file names.
Added a new root_of_unity_powers_ptr option to KeySwitch. This option will be used in HEXL-FPGA.
Addressed the review comments
Signed-off-by: Yan Meng yan.meng@intel.com