[SYCL][ESIMD] Move a few math operations to SPIR-V intrinsics and support new functions #13383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
reviewed
May 8, 2024
sarnex
force-pushed
the
genx
branch
2 times, most recently
from
1acd1b9 to
c91df9b
Compare
sarnex
changed the title
sarnex
changed the title
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
|
CUDA fail not related |
fineg74
approved these changes
Jun 3, 2024
AlexeySachkov
added a commit
to AlexeySachkov/llvm
that referenced
this pull request
Jul 26, 2024
… and support new functions (intel#13383)" This is a partial revert of bcca7a8. Notable changes: - new tests for `popcount`, `clz` and `ctz` built-ins were preserved - public definitions of those ESIMD APIs were preserved - the implementation of the latter was changed, though: - drop template args around `__spirv_ocl_*` intrinsics to use ones that are auto-declared by the compiler - added `#ifdef __SYCL_DEVICE_ONLY__`, because the compiler only declares `__spirv_ocl_*` intrinsics for device compilation
sarnex
pushed a commit
that referenced
this pull request
Jul 29, 2024
ESIMD headers declare some of `__spirv_ocl_*` built-ins as template functions, but those built-ins are also automatically declared by the compiler implicitly when used. On Windows, redeclarations in headers cause compilation issues, because by some reason they take priority, but template arguments for them couldn't be inferred. This commit effectively introduces new tests to cover affected scenarios and reverts a couple of ESIMD commits to fix the issue: - #14020 is completely reverted - #13383 is partially reverted to preserve new interfaces and tests, but stop declaring `__spirv_ocl_*` built-ins I suppose that both PRs were made in attempt to move away from custom ESIMD intrinsic to standard SPIR-V ones, but that should be done without manually declaring the latter. A bigger refactoring might be needed to use auto-declared SPIR-V built-ins in ESIMD because of presence and usage of single-element vectors in ESIMD (which do not exist in SPIR-V).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has three types of changes:
There are some more functions I will move to SPIR-V intrinsincs once driver issues are fixed.