[SYCL][BENCHMARK] Add HIP to benchmarks scripts #17449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/unified-runtime-reviewers Please review, Thanks! |
|
@pbalcer Gentle ping on reviewing this, Thanks! |
omarahmed1111
force-pushed
the
add-hip-to-benchmark-scripts
branch
from
4a98bb2 to
022e23a
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
pbalcer
approved these changes
Mar 25, 2025
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
This looks good, but there's a big PR changing some of the benchmark scripts: |
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Should we wait for it to merge first then merge this, I don't see that there will be a merge conflict (or significant one if any)? |
|
@omarahmed1111, the #17617 is merged now, I guess you can rebase |
omarahmed1111
force-pushed
the
add-hip-to-benchmark-scripts
branch
from
0ff9faa to
e7e04b9
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
omarahmed1111
force-pushed
the
add-hip-to-benchmark-scripts
branch
from
e7e04b9 to
6365b79
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
pbalcer
approved these changes
Mar 26, 2025
lukaszstolarczuk
approved these changes
Mar 26, 2025
|
@intel/llvm-gatekeepers Please merge, Thanks! (failing CI test is not related to this PR, see similar failure) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable benchmarking sycl for hip adapter through VelocityBench and SyclBench in benchmarking scripts.