RFC: [UR] Add non-adapter-specific testing to CI #17509
Draft
+76
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
force-pushed
the
ross/urtest
branch
from
cd5bec5 to
811971c
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
force-pushed
the
ross/urtest
branch
from
811971c to
1d83d15
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
The prefilter.cpp test was failing, this fixes it as follows: * Strings that can't be parsed are now treated as `*:*` rather than `!*:*`. * Backend names are validated; any invalid ones cause the entire string to be rejected. * In ur_lib.cpp, the parser is updated to handle failing to parse the string (doesn't affect the test, but a nice to have). * Some selector strings in the test itself were invalid and updated. This was done according to the specification of ONEAPI_DEVICE_SELECTOR located at https://github.com/intel/llvm/blob/sycl/sycl/doc/EnvironmentVariables.md#oneapi_device_selector .
Currently we only run adapter-specific tests. This adds a new job that runs non-conformance tests.
RossBrunton
force-pushed
the
ross/urtest
branch
from
1d83d15 to
1300ff7
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only run adapter-specific tests. This adds a new
job that runs non-conformance tests.