Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Graph] Improve unsupported node update error #17637

Merged
merged 3 commits into from
Apr 3, 2025
Merged

[SYCL][Graph] Improve unsupported node update error #17637

merged 3 commits into from
Apr 3, 2025

Conversation

Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Mar 25, 2025

  • Include node type in error message
  • Fix unit test triggering topology error instead of unsupported node type error

Example output of new error:

terminate called after throwing an instance of 'sycl::_V1::exception'
  what():  node_type::memfill nodes are not supported for update. Only kernel, host_task, barrier and empty nodes are supported.

@Bensuo Bensuo requested a review from a team as a code owner March 25, 2025 13:30
@Bensuo Bensuo requested a review from reble March 25, 2025 13:30
@Bensuo Bensuo temporarily deployed to WindowsCILock March 25, 2025 13:31 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock March 25, 2025 14:01 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock March 25, 2025 14:01 — with GitHub Actions Inactive
@Bensuo @EwanC
[SYCL][Graph] Improve unsupported node update error
4b1e561 
- Include node type in error message
- Fix unit test triggering topology error instead of unsupported node type error
@EwanC EwanC force-pushed the ben/unsupported-node-error branch from 361df20 to 4b1e561 Compare March 26, 2025 10:05
@Bensuo Bensuo temporarily deployed to WindowsCILock April 1, 2025 12:28 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 1, 2025 12:51 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock April 1, 2025 12:51 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock April 3, 2025 06:50 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock April 3, 2025 07:06 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock April 3, 2025 07:06 — with GitHub Actions Inactive
@EwanC
Copy link
Contributor

EwanC commented Apr 3, 2025

@intel/llvm-gatekeepers This is good to merge

@martygrant martygrant merged commit c410b9a into intel:sycl Apr 3, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwanC EwanC EwanC approved these changes

@reble reble Awaiting requested review from reble reble is a code owner automatically assigned from intel/sycl-graphs-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bensuo @EwanC @martygrant