Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] Fix interop_all_backends for CUDA #17643

Open
wants to merge 4 commits into
base: sycl
Choose a base branch
from

Conversation

npmiller
Copy link
Contributor

The CUDA backend has two different versions of the interop. A legacy version and a newer experimental version. Using the experimental version requires defining a macro before including the SYCL headers. This test uses the experimental version so it should define the macro.

Fixes: #16070

@npmiller npmiller requested a review from a team as a code owner March 25, 2025 18:03
@npmiller npmiller requested a review from slawekptak March 25, 2025 18:03
The CUDA backend has two different versions of the interop. A legacy
version and a newer experimental version. Using the experimental version
requires defining a macro before including the SYCL headers. This test
uses the experimental version so it should define the macro.
Copy link
Contributor

@HPS-1 HPS-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npmiller
Copy link
Contributor Author

npmiller commented Apr 3, 2025

friendly ping @intel/llvm-reviewers-runtime @slawekptak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cuda E2E test fails due to redefinition
2 participants