[SYCL][UR][Graph] Require OpenCL simultaneous use #17658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
force-pushed
the
ewan/graph_ocl_sim-use
branch
from
5a7ffa6 to
858ff7e
Compare
EwanC
force-pushed
the
ewan/graph_ocl_sim-use
branch
from
858ff7e to
f9b1937
Compare
EwanC
force-pushed
the
ewan/graph_ocl_sim-use
branch
from
c65615f to
6fb031f
Compare
EwanC
force-pushed
the
ewan/graph_ocl_sim-use
branch
from
6fb031f to
d610ee8
Compare
aarongreig
reviewed
Mar 31, 2025
aarongreig
approved these changes
Mar 31, 2025
EwanC
force-pushed
the
ewan/graph_ocl_sim-use
branch
from
d610ee8 to
19a961e
Compare
konradkusiak97
approved these changes
Apr 1, 2025
Bensuo
reviewed
Apr 1, 2025
EwanC
force-pushed
the
ewan/graph_ocl_sim-use
branch
from
19a961e to
f879d7b
Compare
To support the SYCL-Graph extension on an OpenCL backend, we currently only require the presence of the `cl_khr_command_buffer` extension. This PR introduces an extra requirement on the [CL_COMMAND_BUFFER_SIMULTANEOUS_USE_KHR](https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_API.html#CL_COMMAND_BUFFER_SIMULTANEOUS_USE_KHR) capability being present. This is based on the [graph execution wording](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc#765-new-handler-member-functions) on the definition of `handler::ext_oneapi_graph()` that: > Only one instance of graph will execute at any time. If graph is submitted multiple times, dependencies are automatically added by the runtime to prevent concurrent executions of an identical graph. Such usage results in multiple calls by the SYCL runtime to `urEnqueueCommandBufferExp` with the same UR command-buffer and event dependencies to prevent concurrent execution. Without support for simultaneous-use the OpenCL adapter code cannot guarantee that the first command-buffer submission has finished execution before it makes following `clEnqueueCommandBufferKHR` calls with the `cl_event` decencies. If the first submission is still executing, then an error will be reported. Workarounds like adding blocking host waits to the OpenCL UR adapter are possible, but requiring simultaneous use reflects the vendor requirements as they are for the currently implementation. I've tried to document this all in the UR spec and SYCL-Graph design docs, which also includes a couple of cleanups I found along the way.
Taken from intel#17709 Co-authored-by: Mikołaj Komar <mikolaj.komar@intel.com>
EwanC
force-pushed
the
ewan/graph_ocl_sim-use
branch
from
f879d7b to
7fab3b7
Compare
|
@intel/llvm-gatekeepers This is good to merge thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the SYCL-Graph extension on an OpenCL backend, we currently only require the presence of the
cl_khr_command_bufferextension. This PR introduces an extra requirement on the CL_COMMAND_BUFFER_SIMULTANEOUS_USE_KHR capability being present.This is based on the graph execution wording on the definition of
handler::ext_oneapi_graph()that:Such usage results in multiple calls by the SYCL runtime to
urEnqueueCommandBufferExpwith the same UR command-buffer and event dependencies to prevent concurrent execution. Without support for simultaneous-use the OpenCL adapter code cannot guarantee that the first command-buffer submission has finished execution before it makes followingclEnqueueCommandBufferKHRcalls with thecl_eventdecencies. If the first submission is still executing, then an error will be reported.Workarounds like adding blocking host waits to the OpenCL UR adapter are possible, but requiring simultaneous use reflects the vendor requirements as they are for the currently implementation. I've tried to document this all in the UR spec and SYCL-Graph design docs, which also includes a couple of cleanups I found along the way.
Note that the new CTS test fails for Level-Zero adapter, which I've created #17734 to resolve.