[Driver] Properly set offload-deps target triple #4305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naghasan
requested review from
AGindinson,
hchilama and
mdtoguchi
as code owners
mdtoguchi
reviewed
Aug 23, 2021
Naghasan
force-pushed
the
victor/fix-offload-deps-target
branch
2 times, most recently
from
c2422b0 to
e0e492f
Compare
For non SPIR target, offload-deps ignored the offloading target arch. This patch set the associated arch to the actions, properly cache the input info when building the job and properly set the `-targets` flag to be aligned with the bundler. Signed-off-by: Victor Lomuller <victor@codeplay.com>
Co-authored-by: mdtoguchi <michael.d.toguchi@intel.com>
Naghasan
force-pushed
the
victor/fix-offload-deps-target
branch
from
d3833fe to
5687526
Compare
Signed-off-by: Victor Lomuller <victor@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non SPIR target, offload-deps ignored the offloading target arch.
This patch set the associated arch to the actions,
properly cache the input info when building the job and
properly set the
-targetsflag to be aligned with the bundler.Signed-off-by: Victor Lomuller victor@codeplay.com