[SYCL][Driver] Fix autodetection of the -Xsycl-target-backend triple #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 2, 2021 12:53
intel#4175 introduced automatic addition of the generic spir64 device target when any section of the input objects had this triple assigned to it. As a result, the actual list of toolchains started exceeding the user-provided one by 1 item. After intel#4239, the above became a problem. The dispatch of -Xsycl-target-* arguments started happening earlier in theflow, which broke the following use-case: ``` clang++ -fsycl -fsycl-targets=spir64_gen gen-obj.o gen-and-spir64-obj.o -Xsycl-target-backend "-device *" ``` A fix for now is to ignore the autodetected spir64 target when propagating the -Xsycl-target-backend arguments. A permanent solution would involve a re-design of -Xsycl-target-backend handling so that it took place only once in the flow, or belating the addition of the autodetected generic triple into the list of device targets. Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
|
Will investigate the Linux failures; I do observe the same crashes locally. |
mdtoguchi
reviewed
Sep 2, 2021
added 2 commits
September 3, 2021 08:23
Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
|
TODO:
UPD: My mistake, re-building the older version correctly introduces the regression back, so nothing to do here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4175 introduced automatic addition
of the generic spir64 device target when any section of the input
objects had this triple assigned to it. As a result, the actual list
of toolchains started exceeding the user-provided one by 1 item.
After #4239, the above became a
problem. The dispatch of -Xsycl-target-* arguments started happening
earlier in theflow, which broke the following use-case:
The fix is to hold off the autodetected generic triple addition until the
GPU architectures have been set based off
-Xsycl-target-backend --offload-arch=values.Signed-off-by: Artem Gindinson artem.gindinson@intel.com