[SYCL] Use incude/sycl/CL as the target to check copied headers #5050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the sycl-headers target calls the copy_directory command, the
command sees that the ${OUT_HEADERS_IN_CL_DIR} output already exists
and the files are already there. Before the patch, the command
looked for the include/CL directory, not include/sycl/CL one, there was
no such directory and the headers were copied again and again.
Now when we ask CMake to build the sycl-headers target twice, the
'Copying SYCL headers ...' message is displayed only after the first
time.
Co-authored-by: tcreech-intel <timothy.m.creech@intel.com>
ghost
requested review from
alexbatashev
approved these changes
Nov 30, 2021
vladimirlaz
approved these changes
Nov 30, 2021
tcreech-intel
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the sycl-headers target calls the copy_directory command, the
command sees that the ${OUT_HEADERS_IN_CL_DIR} output already exists
and the files are already there. Before the patch, the command
looked for the include/CL directory, not include/sycl/CL one, there was
no such directory and the headers were copied again and again.
Now when we ask CMake to build the sycl-headers target twice, the
'Copying SYCL headers ...' message is displayed only after the first
time.
Co-authored-by: tcreech-intel timothy.m.creech@intel.com