Rename common_clang to opencl_clang #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
cdai2
reviewed
Mar 3, 2023
| @@ -101,10 +101,10 @@ else (WIN32) | |||
| endif (WIN32) | |||
|
|
|||
| # set that name of the main output file as a target name | |||
| if (NOT DEFINED COMMON_CLANG_LIBRARY_NAME) | |||
| set(COMMON_CLANG_LIBRARY_NAME "opencl-clang") | |||
| if (NOT DEFINED OPENCL_CLANG_LIBRARY_NAME) | |||
There was a problem hiding this comment.
As we rename this macro. Do we need to notify IGC compiler team? Maybe they use "COMMON_CLANG_LIBRARY_NAME" during their compilation.
There was a problem hiding this comment.
library name in igc build is libopencl-clang.so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename COMMON_CLANG as well.
common_clang is old name, so it is better to rename it.