-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'Visibility' field to Option #474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could someone (maybe @haonanya or @hewj03) please review/merge this ASAP? This is breaking the downstream build. Thanks. |
@bader Can we get this merged first to unblock the build? Thanks. |
wenju-he
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wenju-he
added a commit
to wenju-he/opencl-clang
that referenced
this pull request
Aug 29, 2023
This reverts commit 45180f6.
MingcongBai
pushed a commit
to AOSC-Tracking/opencl-clang
that referenced
this pull request
Mar 8, 2024
MingcongBai
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Mar 8, 2024
- Update preferred LLVM version to 18.1.0. - Backport a patch to fix build with LLVM 18. [^1] - Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0. [^1]: intel/opencl-clang#474
MingcongBai
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Mar 12, 2024
- Update preferred LLVM version to 18.1.0. - Backport a patch to fix build with LLVM 18. [^1] - Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0. [^1]: intel/opencl-clang#474
MingcongBai
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Mar 13, 2024
- Update preferred LLVM version to 18.1.0. - Backport a patch to fix build with LLVM 18. [^1] - Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0. [^1]: intel/opencl-clang#474
MingcongBai
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Mar 13, 2024
- Update preferred LLVM version to 18.1.0. - Backport a patch to fix build with LLVM 18. [^1] - Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0. [^1]: intel/opencl-clang#474
MingcongBai
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Mar 14, 2024
- Update preferred LLVM version to 18.1.0. - Backport a patch to fix build with LLVM 18. [^1] - Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0. [^1]: intel/opencl-clang#474
MingcongBai
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Mar 21, 2024
- Update preferred LLVM version to 18.1.0. - Backport a patch to fix build with LLVM 18. [^1] - Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0. [^1]: intel/opencl-clang#474
MingcongBai
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Apr 26, 2024
- Update preferred LLVM version to 18.1.0. - Backport a patch to fix build with LLVM 18. [^1] - Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0. [^1]: intel/opencl-clang#474
MingcongBai
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Apr 29, 2024
- Update preferred LLVM version to 18.1.0. - Backport a patch to fix build with LLVM 18. [^1] - Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0. [^1]: intel/opencl-clang#474
jiegec
pushed a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
May 20, 2024
- Update preferred LLVM version to 18.1.0. - Backport a patch to fix build with LLVM 18. [^1] - Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0. [^1]: intel/opencl-clang#474
jiegec
pushed a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
May 20, 2024
- Update preferred LLVM version to 18.1.0. - Backport a patch to fix build with LLVM 18. [^1] - Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0. [^1]: intel/opencl-clang#474
jiegec
pushed a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
May 20, 2024
- Update preferred LLVM version to 18.1.0. - Backport a patch to fix build with LLVM 18. [^1] - Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0. [^1]: intel/opencl-clang#474
jiegec
pushed a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
May 20, 2024
- Update preferred LLVM version to 18.1.0. - Backport a patch to fix build with LLVM 18. [^1] - Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0. [^1]: intel/opencl-clang#474
jiegec
pushed a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
May 20, 2024
- Update preferred LLVM version to 18.1.0. - Backport a patch to fix build with LLVM 18. [^1] - Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0. [^1]: intel/opencl-clang#474
jiegec
pushed a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
May 20, 2024
- Update preferred LLVM version to 18.1.0. - Backport a patch to fix build with LLVM 18. [^1] - Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0. [^1]: intel/opencl-clang#474
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by intel/llvm@dcb6d21