Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'Visibility' field to Option #474

Merged
merged 1 commit into from
Aug 16, 2023
Merged

add 'Visibility' field to Option #474

merged 1 commit into from
Aug 16, 2023

Conversation

wwXing0
Copy link
Contributor

@wwXing0 wwXing0 commented Aug 15, 2023 •
edited
Loading

Caused by intel/llvm@dcb6d21

@wwXing0 wwXing0 marked this pull request as ready for review August 15, 2023 11:07
@tylanphear
Copy link
Contributor

Could someone (maybe @haonanya or @hewj03) please review/merge this ASAP? This is breaking the downstream build. Thanks.

@jsji
Copy link
Contributor

jsji commented Aug 15, 2023

@bader Can we get this merged first to unblock the build? Thanks.

@bader
Copy link

bader commented Aug 15, 2023

Can we get this merged first to unblock the build? Thanks.

@jsji, I do not maintain this project anymore, so I'll let @haonanya or @hewj03 to decide.

@jsji
Copy link
Contributor

jsji commented Aug 15, 2023

@jsji, I do not maintain this project anymore, so I'll let @haonanya or @hewj03 to decide.

OK. Thanks.

wenju-he
wenju-he approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@wenju-he wenju-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenju-he wenju-he merged commit 45180f6 into intel:main Aug 16, 2023
@wenju-he wenju-he requested a review from haonanya August 16, 2023 00:12
wenju-he added a commit to wenju-he/opencl-clang that referenced this pull request Aug 29, 2023
@wenju-he
Revert "add 'Visibility' field to Option (intel#474)"
c865758 
This reverts commit 45180f6.
wenju-he added a commit that referenced this pull request Aug 29, 2023
@wenju-he
Revert "add 'Visibility' field to Option (#474)"
1487be5 
This reverts commit 45180f6.
MingcongBai pushed a commit to AOSC-Tracking/opencl-clang that referenced this pull request Mar 8, 2024
@wwXing0 @MingcongBai
add 'Visibility' field to Option (intel#474)
4476f25
MingcongBai added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Mar 8, 2024
@MingcongBai
opencl-clang: fix build with LLVM 18
8a18063 
- Update preferred LLVM version to 18.1.0.
- Backport a patch to fix build with LLVM 18. [^1]
- Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0.

[^1]: intel/opencl-clang#474
MingcongBai added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Mar 12, 2024
@MingcongBai
opencl-clang: fix build with LLVM 18
31573bb 
- Update preferred LLVM version to 18.1.0.
- Backport a patch to fix build with LLVM 18. [^1]
- Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0.

[^1]: intel/opencl-clang#474
MingcongBai added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Mar 13, 2024
@MingcongBai
opencl-clang: fix build with LLVM 18
734a11d 
- Update preferred LLVM version to 18.1.0.
- Backport a patch to fix build with LLVM 18. [^1]
- Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0.

[^1]: intel/opencl-clang#474
MingcongBai added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Mar 13, 2024
@MingcongBai
opencl-clang: fix build with LLVM 18
45301b1 
- Update preferred LLVM version to 18.1.0.
- Backport a patch to fix build with LLVM 18. [^1]
- Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0.

[^1]: intel/opencl-clang#474
MingcongBai added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Mar 14, 2024
@MingcongBai
opencl-clang: fix build with LLVM 18
f50774f 
- Update preferred LLVM version to 18.1.0.
- Backport a patch to fix build with LLVM 18. [^1]
- Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0.

[^1]: intel/opencl-clang#474
MingcongBai added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Mar 21, 2024
@MingcongBai
opencl-clang: fix build with LLVM 18
6fc7704 
- Update preferred LLVM version to 18.1.0.
- Backport a patch to fix build with LLVM 18. [^1]
- Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0.

[^1]: intel/opencl-clang#474
MingcongBai added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Apr 26, 2024
@MingcongBai
opencl-clang: fix build with LLVM 18
8bb08a0 
- Update preferred LLVM version to 18.1.0.
- Backport a patch to fix build with LLVM 18. [^1]
- Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0.

[^1]: intel/opencl-clang#474
MingcongBai added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Apr 29, 2024
@MingcongBai
opencl-clang: fix build with LLVM 18
ffb4c3f 
- Update preferred LLVM version to 18.1.0.
- Backport a patch to fix build with LLVM 18. [^1]
- Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0.

[^1]: intel/opencl-clang#474
jiegec pushed a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request May 20, 2024
@MingcongBai @jiegec
opencl-clang: fix build with LLVM 18
ddb847d 
- Update preferred LLVM version to 18.1.0.
- Backport a patch to fix build with LLVM 18. [^1]
- Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0.

[^1]: intel/opencl-clang#474
jiegec pushed a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request May 20, 2024
@MingcongBai @jiegec
opencl-clang: fix build with LLVM 18
f0ce265 
- Update preferred LLVM version to 18.1.0.
- Backport a patch to fix build with LLVM 18. [^1]
- Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0.

[^1]: intel/opencl-clang#474
jiegec pushed a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request May 20, 2024
@MingcongBai @jiegec
opencl-clang: fix build with LLVM 18
5eee62a 
- Update preferred LLVM version to 18.1.0.
- Backport a patch to fix build with LLVM 18. [^1]
- Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0.

[^1]: intel/opencl-clang#474
jiegec pushed a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request May 20, 2024
@MingcongBai @jiegec
opencl-clang: fix build with LLVM 18
62909b8 
- Update preferred LLVM version to 18.1.0.
- Backport a patch to fix build with LLVM 18. [^1]
- Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0.

[^1]: intel/opencl-clang#474
jiegec pushed a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request May 20, 2024
@MingcongBai @jiegec
opencl-clang: fix build with LLVM 18
2ada969 
- Update preferred LLVM version to 18.1.0.
- Backport a patch to fix build with LLVM 18. [^1]
- Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0.

[^1]: intel/opencl-clang#474
jiegec pushed a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request May 20, 2024
@MingcongBai @jiegec
opencl-clang: fix build with LLVM 18
3efd0dd 
- Update preferred LLVM version to 18.1.0.
- Backport a patch to fix build with LLVM 18. [^1]
- Track patches at AOSC-Tracking/opencl-clang @ aosc/v17.0.0.

[^1]: intel/opencl-clang#474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenju-he wenju-he wenju-he approved these changes

@haonanya haonanya Awaiting requested review from haonanya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wwXing0 @tylanphear @jsji @bader @wenju-he