Add a build option to enable source level coverage analysis #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenju-he
reviewed
Nov 9, 2023
| @@ -161,6 +161,7 @@ std::string EffectiveOptionsFilter::processOptions(const OpenCLArgList &args, | |||
| // The below assert is usable for manual debugging only | |||
| // default: | |||
| // assert(false && "some unknown argument"); | |||
| case OPT_COMPILE_coverage: | |||
There was a problem hiding this comment.
is line-tables-only enough for coverage?
There was a problem hiding this comment.
Yes, line-tables-only is enough. Code coverage doesn't need other information like type.
|
Build failure should be fixed by spirv KhronosGroup/SPIRV-LLVM-Translator#2209. |
wenju-he
reviewed
Nov 9, 2023
| @@ -14,6 +14,7 @@ include "llvm/Option/OptParser.td" | |||
| def g_Flag : Flag<["-"], "g">, HelpText<"Generate source level debug information">; | |||
| def gline_tables_only_Flag : Flag<["-"], "gline-tables-only">; | |||
| def profiling : Flag<["-"], "profiling">, HelpText<"Allow profiling">; | |||
| def coverage: Flag<["-"], "coverage">, HelpText<"Enable source level coverage analysis">; | |||
There was a problem hiding this comment.
Suggested change
| def coverage: Flag<["-"], "coverage">, HelpText<"Enable source level coverage analysis">; | |
| def coverage: Flag<["-"], "code_coverage">, HelpText<"Enable source level coverage analysis">; |
is code_coverage better?
There was a problem hiding this comment.
clang/gcc both use '-coverage'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.