Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base64 dependency to gem spec #107

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Add base64 dependency to gem spec #107

merged 1 commit into from
Jun 21, 2024

Conversation

schneems
Copy link
Collaborator

Eliminates deprecation warning for Ruby 3.4

Close #106

@schneems
Copy link
Collaborator Author

$ bundle exec rake test
/Users/rschneeman/.rubies/ruby-3.3.1/bin/ruby -w -I"lib" -I test /Users/rschneeman/.gem/ruby/3.3.1/gems/rake-13.2.1/lib/rake/rake_test_loader.rb "test/cli_test.rb" "test/client_generator_test.rb" "test/client_test.rb" "test/command_test.rb" "test/configuration_test.rb" "test/heroics_test.rb" "test/link_test.rb" "test/naming_test.rb" "test/resource_test.rb" "test/schema_test.rb" "test/version_test.rb"
Run options: --seed 65519

# Running tests:

............./Users/rschneeman/.gem/ruby/3.3.1/gems/moneta-1.6.0/lib/moneta/transformer.rb:363: warning: too many arguments for format string
....................................................................................................

Finished tests in 0.019784s, 5711.6862 tests/s, 14658.3097 assertions/s.

113 tests, 290 assertions, 0 failures, 0 errors, 0 skips
⛄️ 3.3.1 🚀 /Users/rschneeman/Documents/projects/heroics (schneems/all_ur_base64)
$ git log
commit 6c44f7a9eec4df455452caa06477bfa06d2e8cad (HEAD -> schneems/all_ur_base64, origin/schneems/all_ur_base64)
Author: Schneems <richard.schneeman+foo@gmail.com>
Date:   Thu Jun 20 16:50:38 2024 -0500

    Add base64 dependency to gem spec

    Eliminates deprecation warning for Ruby 3.4

    Close #106

Eliminates deprecation warning for Ruby 3.4

Close #106
@schneems schneems force-pushed the schneems/all_ur_base64 branch from 6c44f7a to aa92ad0 Compare June 20, 2024 21:55
@schneems
Copy link
Collaborator Author

Updated to add changelog and rev the version:

$ git rev-parse --short HEAD
aa92ad0
⛄️ 3.3.1 🚀 /Users/rschneeman/Documents/projects/heroics (schneems/all_ur_base64)
$ bundle exec rake test
/Users/rschneeman/.rubies/ruby-3.3.1/bin/ruby -w -I"lib" -I test /Users/rschneeman/.gem/ruby/3.3.1/gems/rake-13.2.1/lib/rake/rake_test_loader.rb "test/cli_test.rb" "test/client_generator_test.rb" "test/client_test.rb" "test/command_test.rb" "test/configuration_test.rb" "test/heroics_test.rb" "test/link_test.rb" "test/naming_test.rb" "test/resource_test.rb" "test/schema_test.rb" "test/version_test.rb"
Run options: --seed 63690

# Running tests:

............/Users/rschneeman/.gem/ruby/3.3.1/gems/moneta-1.6.0/lib/moneta/transformer.rb:363: warning: too many arguments for format string
.....................................................................................................

Finished tests in 0.019522s, 5788.3414 tests/s, 14855.0353 assertions/s.

113 tests, 290 assertions, 0 failures, 0 errors, 0 skips

Copy link

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :-)

@schneems schneems merged commit cf361ab into main Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

base64 deprecation warning with Ruby 3.3
2 participants