Replace HTML anchor tags with Markdown #337
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichOrElse
force-pushed
the
feature/markdown-style-toc-headers
branch
from
250c821 to
a1c64d5
Compare
|
Prior to this change, I think the titles would be links themselves (so you could click on them to have the anchor appear in the navigation bar), whereas after this I think the anchors would be purely hidden? Does that line up with your expectation? I think maybe being able to click can sometimes help people to discover/remember the anchors, but maybe it's more trouble than it is worth as your version certainly makes the raw output more readable. What do you think? |
|
I only wanted a cosmetic change, didn't want to remove the functionality provided by named anchor tags. That's why I revised and overwritten my previous commit. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.