ci: add performance script to PR jobs #3274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- currently requires running tests to setup db (waiting to avoid actually running tests and spinning down tests/env) - loses ability to run k6 against rafiki w/ telemetry
This reverts commit 1a6c0e6.
- in preparation for switching performance test to target testenv - ensured integration tests pass
- supports reuse in setup script for performance tests which will allow running performance test against testenv - also bumps graphql pacakge version across monorepo. added to test-lib which caused some type errors in backend and auth due to a version mismatch
github-actions
bot
added
type: tests
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
BlairCurrey
changed the title
koekiebox
requested changes
Mar 10, 2025
test/performance/config/local.env
Outdated
| C9_OPEN_PAYMENTS_PORT="3000" | ||
| C9_GRAPHQL_PORT="3001" | ||
| HLB_OPEN_PAYMENTS_PORT="4000" | ||
| DOCKER_NETWORK="rafiki_rafiki" |
test/performance/config/test.env
Outdated
| C9_OPEN_PAYMENTS_PORT="3100" | ||
| C9_GRAPHQL_PORT="3101" | ||
| HLB_OPEN_PAYMENTS_PORT="4100" | ||
| DOCKER_NETWORK="rafiki-test_rafiki-test" |
Comment on lines
+165
to
+188
| export function handleSummary(data) { | ||
| const requestsPerSecond = data.metrics.http_reqs.values.rate | ||
| const iterationsPerSecond = data.metrics.iterations.values.rate | ||
| const failedRequests = data.metrics.http_req_failed.values.passes | ||
| const failureRate = data.metrics.http_req_failed.values.rate | ||
| const requests = data.metrics.http_reqs.values.count | ||
|
|
||
| const summaryText = ` | ||
| **Test Configuration**: | ||
| - VUs: ${options.vus} | ||
| - Duration: ${options.duration} | ||
|
|
||
| **Test Metrics**: | ||
| - Requests/s: ${requestsPerSecond.toFixed(2)} | ||
| - Iterations/s: ${iterationsPerSecond.toFixed(2)} | ||
| - Failed Requests: ${failureRate.toFixed(2)}% (${failedRequests} of ${requests}) | ||
| ` | ||
|
|
||
| return { | ||
| // Preserve standard output w/ textSummary | ||
| stdout: textSummary(data, { enableColors: false }), | ||
| 'k6-test-summary.txt': summaryText // saves to file | ||
| } | ||
| } |
There was a problem hiding this comment.
We could also save a summary HTML report via:
import { htmlReport } from 'https://raw.githubusercontent.com/benc-uk/k6-reporter/main/dist/bundle.js';
// Report handling
/**
* Report Generation
* Handles the generation of test result reports
* @param {Object} data - Test result data from K6
* @returns {Object} Report configuration object
*/
export function handleSummary(data) {
return {
'reports/summary.html': htmlReport(data)
};
}
|
@koekiebox Tried out the html report. Looks nice. I dont see a straightforward way to get in the PR. Perhaps it could be used locally, although I think in that case the cli has the same info and you dont have to go hunt it down.
|
mkurapov
previously approved these changes
Mar 12, 2025
njlie
previously approved these changes
Mar 12, 2025
njlie
approved these changes
Mar 14, 2025
mkurapov
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
MockASEhandles seeding and hosting integration endpoints required for rafiki to properly function (rates, webhooks). This is located in the integration tests inmainso I moved it out for re-use when running performance tests.mainrun against our localenv. I changed it to be configurable by parameterizing the run script and test and reading from a config to get the correct environment details (network name, urls). So now you could run performance tests locally against the testenv without interference with your localenv. And can still run against localenv if you want to use the grafana dashboard.The PR comment got buried here (shouldnt happen normally, will be one of the first comments w/ netlift): #3274 (comment)
Context
fixes: #3240
Checklist
fixes #numberuser-docslabel (if necessary)