[scd] minimal implementation for the dss report handler

[Shastick]

An implementation for the dss report handler that simply logs the report as a Json string.

(This is to have a version to develop a simple test scenario against, but the goal would be to have something that we can possibly ship)

[mickmis]

Please check the two comments I've left.
Also, have you tried invoking this endpoint locally to validate it works as expected? Just for safety before merging.
Otherwise LGTM

[mickmis]

nit: name the interface DSSReportHandler and the function inside Handle, that is more aligned with Go best practices
(incidentally that will remove the mixed case Dss :) )

[Shastick]

I was considering this but avoided it, because we already have some files called *_handlers that seem to be specifically about handling REST calls?

This interfaces is about handling things after they traversed the MakeDssReport function in dss_report_handler and it feels a bit weird to pass that to an interface called DSSReportHandler?

(Having things in a separate package would make it clearer: I'm open to suggestions)

[mickmis]

True that. That's a reason why I'm not a fan of defining interfaces ahead of time without it being actually in use TBH (c.f. as well this). But that's (still) nitpicking so I'm good merging it as it is. I leave it up to you.

[Shastick]

Thanks for the pointer. I'm still thinking too much in terms of Java interfaces -> i did some renaming to get closer to the recommendations.

[Shastick]

Also, have you tried invoking this endpoint locally to validate it works as expected? Just for safety before merging.
Otherwise LGTM

Yes, I wrote a tiny test scenario. I'll run it again now to be sure