[terraform] Make cockroach DB cluster name configurable #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[terraform] add configuration variable crdb_cluster_name
barroco
force-pushed
the
tf-crdb-cluster-name
branch
from
90c1afc to
d0d98e8
Compare
barroco
force-pushed
the
tf-crdb-cluster-name
branch
from
d0d98e8 to
260a6d6
Compare
mickmis
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the hardcoded cluster name by a configuration flag. This field is required.
For previous deployments, it has to be populated with
dss-aws-1.This is currently only required for helm deployments.
Tanka uses an empty value which generates a random name.
A remark will be added to the next release note.