Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infrastructure] Add variable to set kubernetes cluster version. Default to 1.24 #989

Merged
merged 1 commit into from
Jan 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ resource "aws_eks_cluster" "kubernetes_cluster" {
aws_eip.ip_crdb
]

version = "1.24"
version = var.kubernetes_version
}

resource "aws_eks_node_group" "eks_node_group" {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,3 +87,19 @@ variable "node_count" {
}
}

variable "kubernetes_version" {
type = string
description = <<-EOT
Desired version of the Kubernetes cluster control plane and nodes.

Supported versions:
- 1.24
EOT

validation {
condition = var.kubernetes_version == "1.24"
error_message = "Only 1.24 is supported."
}
}


Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ resource "google_container_cluster" "kubernetes_cluster" {
ip_allocation_policy {
# Intentionally left empty.
}

min_master_version = var.kubernetes_version
}

resource "google_container_node_pool" "dss_pool" {
Expand Down Expand Up @@ -55,4 +57,4 @@ resource "google_compute_address" "ip_crdb" {

locals {
kubectl_cluster_context_name = format("gke_%s_%s_%s", google_container_cluster.kubernetes_cluster.project, google_container_cluster.kubernetes_cluster.location, google_container_cluster.kubernetes_cluster.name)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,19 @@ variable "node_count" {
}
}

variable "kubernetes_version" {
type = string
description = <<-EOT
Desired version of the Kubernetes cluster control plane and nodes.

Supported versions:
- 1.24
EOT

validation {
condition = var.kubernetes_version == "1.24"
error_message = "Only 1.24 is supported."
}
}


10 changes: 10 additions & 0 deletions deploy/infrastructure/modules/terraform-aws-dss/TFVARS.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,16 @@ Number of Kubernetes nodes which should correspond to the desired CockroachDB no
Example: `3`


### kubernetes_version

*Type: `string`*

Desired version of the Kubernetes cluster control plane and nodes.

Supported versions:
- 1.24


### aws_kubernetes_storage_class

*Type: `string`*
Expand Down
1 change: 1 addition & 0 deletions deploy/infrastructure/modules/terraform-aws-dss/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ module "terraform-aws-kubernetes" {
aws_route53_zone_id = var.aws_route53_zone_id
aws_iam_permissions_boundary = var.aws_iam_permissions_boundary
node_count = var.node_count
kubernetes_version = var.kubernetes_version

source = "../../dependencies/terraform-aws-kubernetes"
}
Expand Down
16 changes: 16 additions & 0 deletions deploy/infrastructure/modules/terraform-aws-dss/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,22 @@ variable "node_count" {
}
}

variable "kubernetes_version" {
type = string
description = <<-EOT
Desired version of the Kubernetes cluster control plane and nodes.

Supported versions:
- 1.24
EOT

validation {
condition = var.kubernetes_version == "1.24"
error_message = "Only 1.24 is supported."
}
}


variable "aws_kubernetes_storage_class" {
type = string
description = <<-EOT
Expand Down
7 changes: 4 additions & 3 deletions deploy/infrastructure/modules/terraform-google-dss/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ Download & install the following tools to your workstation:
2. Check that the DSS project is correctly selected: gcloud config list project
1. Set another one if needed using: `gcloud config set project $GOOGLE_PROJECT_NAME`
3. Enable the following API using [Google Cloud CLI](https://cloud.google.com/endpoints/docs/openapi/enable-api#gcloud):
1. `container.googleapis.com`
2. If you want to manage DNS entries with terraform: `dns.googleapis.com`
1. `compute.googleapis.com`
2. `container.googleapis.com`
3. If you want to manage DNS entries with terraform: `dns.googleapis.com`
4. Install the auth plugin to connect to kubernetes: `gcloud components install gke-gcloud-auth-plugin`
5. Run `gcloud auth application-default login` to generate credentials to call Google Cloud Platform APIs.
1. If the result of performing the authorization indicates 404 in the browser, check whether a local dummy-oauth instance is running (using port 8085). Stop the dummy-oauth instance if it is running.
Expand Down Expand Up @@ -70,4 +71,4 @@ It contains scripts to operate the cluster and setup the services.

To delete all resources, run `terraform destroy`. Note that this operation can't be reverted and all data will be lost.

For Google Cloud Engine, make sure to manually clean up the persistent storage: https://console.cloud.google.com/compute/disks
For Google Cloud Engine, make sure to manually clean up the persistent storage: https://console.cloud.google.com/compute/disks
10 changes: 10 additions & 0 deletions deploy/infrastructure/modules/terraform-google-dss/TFVARS.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,16 @@ Number of Kubernetes nodes which should correspond to the desired CockroachDB no
Example: `3`


### kubernetes_version

*Type: `string`*

Desired version of the Kubernetes cluster control plane and nodes.

Supported versions:
- 1.24


### google_kubernetes_storage_class

*Type: `string`*
Expand Down
1 change: 1 addition & 0 deletions deploy/infrastructure/modules/terraform-google-dss/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ module "terraform-google-kubernetes" {
google_dns_managed_zone_name = var.google_dns_managed_zone_name
google_machine_type = var.google_machine_type
node_count = var.node_count
kubernetes_version = var.kubernetes_version

source = "../../dependencies/terraform-google-kubernetes"
}
Expand Down
16 changes: 16 additions & 0 deletions deploy/infrastructure/modules/terraform-google-dss/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,22 @@ variable "node_count" {
}
}

variable "kubernetes_version" {
type = string
description = <<-EOT
Desired version of the Kubernetes cluster control plane and nodes.

Supported versions:
- 1.24
EOT

validation {
condition = var.kubernetes_version == "1.24"
error_message = "Only 1.24 is supported."
}
}


variable "google_kubernetes_storage_class" {
type = string
description = <<-EOT
Expand Down
8 changes: 5 additions & 3 deletions deploy/infrastructure/utils/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

This directory contains the following tools to simplify the management of the terraform modules:

1. `generate_terraform_variables.sh`: Terraform variables can't be shared between modules without repeating their definition at every level of encapsulation.
To prevent repeating ourselves and to maintain a consistent level of quality for every module and dependencies, this script takes variables
in the `definitions` directory and creates a `variables.tf` file in each modules with the appropriate content.
## `generate_terraform_variables.sh`
Terraform variables can't be shared between modules without repeating their definition at every level of encapsulation.
To prevent repeating ourselves and to maintain a consistent level of quality for every module and dependencies, this script takes variables
in the `definitions` directory and creates a `variables.tf` file in each modules with the appropriate content.
Assignment of `definitions` files to modules is made in `variables.py`.
14 changes: 14 additions & 0 deletions deploy/infrastructure/utils/definitions/kubernetes_version.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
variable "kubernetes_version" {
type = string
description = <<-EOT
Desired version of the Kubernetes cluster control plane and nodes.

Supported versions:
- 1.24
EOT

validation {
condition = var.kubernetes_version == "1.24"
error_message = "Only 1.24 is supported."
}
}
3 changes: 2 additions & 1 deletion deploy/infrastructure/utils/variables.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,14 @@
"desired_scd_db_version",
"crdb_locality",
"crdb_external_nodes",
"kubernetes_namespace",
"kubernetes_namespace"
]

# dependencies/terraform-*-kubernetes
COMMON_KUBERNETES_VARIABLES = GLOBAL_VARIABLES + [
"cluster_name",
"node_count",
"kubernetes_version"
]

# dependencies/terraform-google-kubernetes
Expand Down
1 change: 1 addition & 0 deletions deploy/operations/ci/aws-1/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ module "terraform-aws-dss" {
crdb_hostname_suffix = var.crdb_hostname_suffix
crdb_locality = var.crdb_locality
image = var.image
kubernetes_version = var.kubernetes_version
node_count = 3
should_init = true
enable_scd = true
Expand Down
1 change: 1 addition & 0 deletions deploy/operations/ci/aws-1/terraform.tfvars
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ app_hostname = "dss.ci.aws-interuss.uspace.dev"
crdb_hostname_suffix = "db.ci.aws-interuss.uspace.dev"

# Kubernetes configuration
kubernetes_version = 1.24
cluster_name = "dss-ci-aws-ue1"
node_count = 3
aws_instance_type = "t3.medium"
Expand Down
16 changes: 16 additions & 0 deletions deploy/operations/ci/aws-1/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,22 @@ variable "node_count" {
}
}

variable "kubernetes_version" {
type = string
description = <<-EOT
Desired version of the Kubernetes cluster control plane and nodes.

Supported versions:
- 1.24
EOT

validation {
condition = var.kubernetes_version == "1.24"
error_message = "Only 1.24 is supported."
}
}


variable "aws_kubernetes_storage_class" {
type = string
description = <<-EOT
Expand Down
Loading