Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Attachment permissions #7863

Merged

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Aug 13, 2024

  • Fixes a bug where attachments cannot be deleted via the API, due to incorrect permission checks.
  • Re-enable bulk delete of attachments
  • Validation for attachment bulk delete

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed user interface backport Apply this label to a PR to enable auto-backport action labels Aug 13, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Aug 13, 2024
Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit b556d65
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66bae7d95c48bd00085458bf

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.39%. Comparing base (e6873d2) to head (b556d65).
Report is 324 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/common/api.py 30.00% 7 Missing ⚠️
src/backend/InvenTree/common/serializers.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7863   +/-   ##
=======================================
  Coverage   83.39%   83.39%           
=======================================
  Files        1128     1128           
  Lines       50233    50259   +26     
  Branches     1728     1728           
=======================================
+ Hits        41893    41916   +23     
- Misses       7905     7910    +5     
+ Partials      435      433    -2     
Flag Coverage Δ
backend 85.22% <74.19%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 831b129 into inventree:master Aug 13, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the attachment-permissions branch August 13, 2024 05:22
@SchrodingersGat SchrodingersGat added the CI CI / unit testing ecosystem label Aug 13, 2024
Copy link
Contributor

💔 All backports failed

Status Branch Result
0.16.x Backport failed because of merge conflicts

You might need to backport the following PRs to 0.16.x:
- Metadata api fix (#7829)

Manual backport

To create the backport manually run:

backport --pr 7863

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Apply this label to a PR to enable auto-backport action bug Identifies a bug which needs to be addressed CI CI / unit testing ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant