Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Check length before access #7923

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

SchrodingersGat
Copy link
Member

  • Small bug fix for checking array length before accessing

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed user interface User Interface Related to the frontend / User Interface labels Aug 19, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Aug 19, 2024
Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 7c39007
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66c2ebd97f12df00080f46ee
😎 Deploy Preview https://deploy-preview-7923--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SchrodingersGat SchrodingersGat merged commit 6572e64 into inventree:master Aug 19, 2024
25 checks passed
@SchrodingersGat SchrodingersGat deleted the length-fix branch August 19, 2024 07:12
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.38%. Comparing base (d6218b7) to head (7c39007).
Report is 314 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/pages/part/PartDetail.tsx 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7923      +/-   ##
==========================================
- Coverage   83.39%   83.38%   -0.01%     
==========================================
  Files        1131     1131              
  Lines       50389    50403      +14     
  Branches     1754     1758       +4     
==========================================
+ Hits        42020    42031      +11     
- Misses       7923     7924       +1     
- Partials      446      448       +2     
Flag Coverage Δ
pui 64.75% <33.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant