Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] fix missing key in currency table #7953

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Aug 21, 2024

The currency table in the AdminCenter is missing an accessor - this sometimes throws errors when returning to the tab after a while.

@matmair matmair added bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface labels Aug 21, 2024
@matmair matmair added this to the 0.17.0 milestone Aug 21, 2024
@matmair matmair self-assigned this Aug 21, 2024
@matmair matmair marked this pull request as ready for review August 21, 2024 19:54
Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 4c05753
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66c645dd1b010f00085a2790
😎 Deploy Preview https://deploy-preview-7953--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.52%. Comparing base (0c63e50) to head (4c05753).
Report is 309 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7953      +/-   ##
==========================================
+ Coverage   83.49%   83.52%   +0.02%     
==========================================
  Files        1130     1130              
  Lines       50470    50470              
  Branches     1755     1755              
==========================================
+ Hits        42138    42153      +15     
+ Misses       7878     7863      -15     
  Partials      454      454              
Flag Coverage Δ
pui 65.54% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@SchrodingersGat SchrodingersGat merged commit 725181b into inventree:master Aug 21, 2024
28 checks passed
@SchrodingersGat SchrodingersGat deleted the pui-fix-missing-key branch August 21, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants