Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Link fix #8726

Merged
merged 1 commit into from
Dec 20, 2024
Merged

[UI] Link fix #8726

merged 1 commit into from
Dec 20, 2024

Conversation

SchrodingersGat
Copy link
Member

  • Fixes anchor issues in stock tracking table

@SchrodingersGat
[UI] Link fix
899107f 
- Fixes anchor issues in stock tracking table
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed backport Apply this label to a PR to enable auto-backport action User Interface Related to the frontend / User Interface backport-to-0.17.x Backport these changes to the 0.17.x branch labels Dec 20, 2024
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Dec 20, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 20, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 899107f
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6764c076dbf9b80008bdbe61
😎 Deploy Preview https://deploy-preview-8726--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.21%. Comparing base (aad5575) to head (899107f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/components/render/Instance.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8726      +/-   ##
==========================================
- Coverage   85.25%   85.21%   -0.05%     
==========================================
  Files        1175     1175              
  Lines       52432    52432              
  Branches     2079     2079              
==========================================
- Hits        44702    44680      -22     
- Misses       7229     7245      +16     
- Partials      501      507       +6
Flag Coverage Δ
pui 68.86% <0.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 68ac411 into inventree:master Dec 20, 2024
31 checks passed
@SchrodingersGat SchrodingersGat deleted the tracking-links branch December 20, 2024 01:21
github-actions bot pushed a commit that referenced this pull request Dec 20, 2024
@SchrodingersGat
[UI] Link fix (#8726)
beb1bc1 
- Fixes anchor issues in stock tracking table

(cherry picked from commit 68ac411)
@github-actions github-actions bot mentioned this pull request Dec 20, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 0.17.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

SchrodingersGat added a commit that referenced this pull request Dec 20, 2024
@github-actions @SchrodingersGat
[UI] Link fix (#8726) (#8728)
70f1799 
- Fixes anchor issues in stock tracking table

(cherry picked from commit 68ac411)

Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Apply this label to a PR to enable auto-backport action backport-to-0.17.x Backport these changes to the 0.17.x branch bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@SchrodingersGat