Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle error when loading icon pack #8753

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Handle error when loading icon pack #8753

merged 2 commits into from
Dec 23, 2024

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Dec 23, 2024 •
edited
Loading

Display error message if loading a font pack fails.

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed backport Apply this label to a PR to enable auto-backport action User Interface Related to the frontend / User Interface backport-to-0.17.x Backport these changes to the 0.17.x branch labels Dec 23, 2024
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Dec 23, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 23, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit ebe9cd2
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6769e91e7b8d840008a2b359
😎 Deploy Preview https://deploy-preview-8753--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.75%. Comparing base (ec6280d) to head (ebe9cd2).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/states/IconState.tsx 66.66% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8753      +/-   ##
==========================================
+ Coverage   84.66%   84.75%   +0.08%     
==========================================
  Files        1175     1175              
  Lines       51832    51855      +23     
  Branches     2087     2090       +3     
==========================================
+ Hits        43886    43949      +63     
+ Misses       7448     7390      -58     
- Partials      498      516      +18
Flag Coverage Δ
pui 69.46% <66.66%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 8fcebef into inventree:master Dec 23, 2024
27 checks passed
@SchrodingersGat SchrodingersGat deleted the font-load-err branch December 23, 2024 23:18
github-actions bot pushed a commit that referenced this pull request Dec 23, 2024
@SchrodingersGat
Handle error when loading icon pack (#8753)
e3831e0 
* Handle error when loading icon pack

* Update

(cherry picked from commit 8fcebef)
@github-actions GitHub Actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 0.17.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions github-actions bot mentioned this pull request Dec 23, 2024
Merged
SchrodingersGat added a commit that referenced this pull request Dec 23, 2024
@github-actions @SchrodingersGat
Handle error when loading icon pack (#8753) (#8755)
3cb806d 
* Handle error when loading icon pack

* Update

(cherry picked from commit 8fcebef)

Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Apply this label to a PR to enable auto-backport action backport-to-0.17.x Backport these changes to the 0.17.x branch bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@SchrodingersGat