Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package install in envs using python lower than 3.12 on debian like OSs #8793

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Fix package install in envs using python lower than 3.12 on debian like OSs #8793

merged 2 commits into from
Dec 31, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Dec 30, 2024

This fixes issues where uv installs the wrong version of a package. It might be wise to use the uv lockfile in the future to ensure this does not happen again, that requires more work though

@matmair matmair added bug Identifies a bug which needs to be addressed installer backport-to-0.17.x Backport these changes to the 0.17.x branch labels Dec 30, 2024
@matmair matmair added this to the 0.17.2 milestone Dec 30, 2024
@matmair matmair self-assigned this Dec 30, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 1d85278
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6772bbb901658c0008b06dd4

@matmair matmair changed the title Fix package install usinf python lower than 3.12 on debian like OSs Fix package install in envs using python lower than 3.12 on debian like OSs Dec 30, 2024
@SchrodingersGat
Copy link
Member

Is this in relation to any particular outstanding issues?

@matmair
Copy link
Member Author

matmair commented Dec 31, 2024

as listed in the commits #8789 #8742 #8495 #8494

@matmair matmair mentioned this pull request Dec 31, 2024
Closed
7 tasks
@SchrodingersGat SchrodingersGat merged commit d7939ef into inventree:master Dec 31, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the fix-package-install-python branch December 31, 2024 12:13
This was referenced Dec 31, 2024
Closed
Closed
@SchrodingersGat SchrodingersGat added the backport Apply this label to a PR to enable auto-backport action label Dec 31, 2024
github-actions bot pushed a commit that referenced this pull request Dec 31, 2024
@matmair
Fix package install in envs using python lower than 3.12 on debian li…
86a76c0 
…ke OSs (#8793)

* do not install with uv for now - fixes #8789
#8742 #8495 #8494

* Ensure errors are raised if install / update fails

(cherry picked from commit d7939ef)
@github-actions GitHub Actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 0.17.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions github-actions bot mentioned this pull request Dec 31, 2024
Merged
SchrodingersGat pushed a commit that referenced this pull request Dec 31, 2024
@github-actions @matmair
Fix package install in envs using python lower than 3.12 on debian li…
d42e308 
…ke OSs (#8793) (#8813)

* do not install with uv for now - fixes #8789
#8742 #8495 #8494

* Ensure errors are raised if install / update fails

(cherry picked from commit d7939ef)

Co-authored-by: Matthias Mair <code@mjmair.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matmair matmair

Labels
backport Apply this label to a PR to enable auto-backport action backport-to-0.17.x Backport these changes to the 0.17.x branch bug Identifies a bug which needs to be addressed installer
Projects
None yet
Milestone
0.17.2
Development

Successfully merging this pull request may close these issues.
2 participants
@matmair @SchrodingersGat