Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import fix #8924

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Import fix #8924

merged 2 commits into from
Jan 20, 2025

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat
Exclude "tags" fields from data import
1644618 
- May reintroduce at a later date
- Currently, no support for editing tags in frontend
@SchrodingersGat
Refactor
4e23443
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed import / export Data importing, exporting and processing backport Apply this label to a PR to enable auto-backport action backport-to-0.17.x Backport these changes to the 0.17.x branch labels Jan 20, 2025
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Jan 20, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 20, 2025 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 4e23443
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/678e57e4c81bad000850fa46
😎 Deploy Preview https://deploy-preview-8924--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Jan 20, 2025
Closed
Open
@SchrodingersGat SchrodingersGat merged commit 2575c72 into inventree:master Jan 20, 2025
28 checks passed
@SchrodingersGat SchrodingersGat deleted the import-fix branch January 20, 2025 14:24
github-actions bot pushed a commit that referenced this pull request Jan 20, 2025
@SchrodingersGat
Import fix (#8924)
c81ef34 
* Exclude "tags" fields from data import

- May reintroduce at a later date
- Currently, no support for editing tags in frontend

* Refactor

(cherry picked from commit 2575c72)
@github-actions github-actions bot mentioned this pull request Jan 20, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 0.17.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.44%. Comparing base (37c8418) to head (4e23443).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/importer/mixins.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8924      +/-   ##
==========================================
- Coverage   85.14%   84.44%   -0.70%     
==========================================
  Files        1175     1176       +1     
  Lines       51779    52680     +901     
  Branches     2106     2106              
==========================================
+ Hits        44085    44486     +401     
- Misses       7160     7660     +500     
  Partials      534      534
Flag Coverage Δ
backend 86.95% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SchrodingersGat added a commit that referenced this pull request Jan 20, 2025
@github-actions @SchrodingersGat
Import fix (#8924) (#8926)
ee06e46 
* Exclude "tags" fields from data import

- May reintroduce at a later date
- Currently, no support for editing tags in frontend

* Refactor

(cherry picked from commit 2575c72)

Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Apply this label to a PR to enable auto-backport action backport-to-0.17.x Backport these changes to the 0.17.x branch bug Identifies a bug which needs to be addressed import / export Data importing, exporting and processing refactor
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

import csv file / TAGS error on mapping
1 participant
@SchrodingersGat