Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for data import #9060

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Fix for data import #9060

merged 1 commit into from
Feb 11, 2025

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat
Fix for data import
c68be4a 
- Prevent shadow overwrite of default_values dict
- Remove dead code
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed import / export Data importing, exporting and processing backport Apply this label to a PR to enable auto-backport action backport-to-0.17.x Backport these changes to the 0.17.x branch labels Feb 11, 2025
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Feb 11, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 11, 2025 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit c68be4a
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67ab39b9c9712c000883a7c4

@SchrodingersGat SchrodingersGat mentioned this pull request Feb 11, 2025
Closed
6 tasks
@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.56%. Comparing base (8493e5a) to head (c68be4a).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9060      +/-   ##
==========================================
+ Coverage   85.55%   85.56%   +0.01%     
==========================================
  Files        1177     1177              
  Lines       52041    52032       -9     
  Branches     2120     2120              
==========================================
- Hits        44523    44522       -1     
+ Misses       6984     6976       -8     
  Partials      534      534
Flag Coverage Δ
backend 87.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 7049e84 into inventree:master Feb 11, 2025
31 checks passed
@SchrodingersGat SchrodingersGat deleted the data-import-fix branch February 11, 2025 20:24
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
@SchrodingersGat
Fix for data import (#9060)
cc583df 
- Prevent shadow overwrite of default_values dict
- Remove dead code

(cherry picked from commit 7049e84)
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 0.17.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

SchrodingersGat added a commit that referenced this pull request Feb 11, 2025
@github-actions @SchrodingersGat
Fix for data import (#9060) (#9065)
3b6b419 
- Prevent shadow overwrite of default_values dict
- Remove dead code

(cherry picked from commit 7049e84)

Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matmair matmair matmair approved these changes

Assignees
No one assigned
Labels
backport Apply this label to a PR to enable auto-backport action backport-to-0.17.x Backport these changes to the 0.17.x branch bug Identifies a bug which needs to be addressed import / export Data importing, exporting and processing
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Import - Empty cells unexpectedly replaced by previous row
2 participants
@SchrodingersGat @matmair