Avoid requiring the tax to be present

invopop · Jan 30, 2025 · 278986c · 278986c
1 parent a2443d1
commit 278986c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/addons/pt/saft/invoices.go b/addons/pt/saft/invoices.go
@@ -28,7 +28,6 @@ var (
 func validateInvoice(inv *bill.Invoice) error {
 	return validation.ValidateStruct(inv,
 		validation.Field(&inv.Tax,
-			validation.Required,
 			validation.By(validateTax),
 			validation.Skip,
 		),
@@ -60,7 +59,7 @@ func validateInvoice(inv *bill.Invoice) error {
 func validateTax(val any) error {
 	t, _ := val.(*bill.Tax)
 	if t == nil {
-		return nil
+		t = new(bill.Tax)
 	}
 
 	return validation.ValidateStruct(t,

diff --git a/addons/pt/saft/invoices_test.go b/addons/pt/saft/invoices_test.go
@@ -68,7 +68,7 @@ func TestInvoiceValidation(t *testing.T) {
 		inv := validInvoice()
 
 		inv.Tax = nil
-		assert.ErrorContains(t, addon.Validator(inv), "tax: cannot be blank")
+		assert.ErrorContains(t, addon.Validator(inv), "tax: (ext: (pt-saft-invoice-type: required")
 
 		inv.Tax = new(bill.Tax)
 		assert.ErrorContains(t, addon.Validator(inv), "tax: (ext: (pt-saft-invoice-type: required")