Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing validation of advance key check in EN16931 addon #458

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

samlown
Copy link
Collaborator

@samlown samlown commented Feb 11, 2025

  • Fixes issue when validating presence of a payment advance key, which is not a strict requirement of EN16931
  • Also including fix to reduce requirements on payment card fields

Pre-Review Checklist

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents to show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes, either structured or in the comments.
  • I've run go generate . to ensure that the Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (191492f) to head (49c964e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   85.17%   85.15%   -0.03%     
==========================================
  Files         255      255              
  Lines       12595    12576      -19     
==========================================
- Hits        10728    10709      -19     
  Misses       1518     1518              
  Partials      349      349              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samlown samlown merged commit 9f5e454 into main Feb 11, 2025
7 checks passed
@samlown samlown deleted the fix-en16931-advances branch February 11, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants