Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slides): add support for Swiper 7 #24190

Merged
merged 5 commits into from
Nov 9, 2021
Merged

feat(slides): add support for Swiper 7 #24190

merged 5 commits into from
Nov 9, 2021

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 9, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

We previously shipped a module to make Ionic compatible with the vanilla Swiper.js library, but the plugin is only compatible up to Swiper 6.

What is the new behavior?

  • Adds a new IonicSlides module for developers to use with Swiper 7. Swiper 7 fixes issues with async initialization so this module only concerns itself with automatically setting the default settings that were found in the old ion-slides component (see: https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/slides/slides.tsx#L376)
  • Deprecated the IonicSwiper module for Swiper 6. The IonicSwiper module will be removed in Ionic 7. This means Swiper 6 will not be supported in Ionic 7.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package labels Nov 9, 2021
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants