Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(content): remove global click listener to improve interaction performance #24360

Merged
merged 1 commit into from
Dec 10, 2021
Merged

perf(content): remove global click listener to improve interaction performance #24360

merged 1 commit into from
Dec 10, 2021

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #24359
See #24359 (comment) for context

What is the new behavior?

  • Removed the global click listener on ion-content

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Dec 9, 2021
@sean-perkins sean-perkins changed the title perf(content): remove global click listener to improve interaction rformance perf(content): remove global click listener to improve interaction performance Dec 10, 2021
sean-perkins
sean-perkins approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I did some light testing with the dev build in a starter app on device. Things look good.

averyjohnston
averyjohnston approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well 👍

@liamdebeasi liamdebeasi merged commit 1bfac52 into main Dec 10, 2021
@liamdebeasi liamdebeasi mentioned this pull request Dec 10, 2021
Closed
6 tasks
@liamdebeasi liamdebeasi deleted the FW-412 branch December 10, 2021 15:35
liamdebeasi added a commit that referenced this pull request Dec 15, 2021
@liamdebeasi
perf(content): remove global click listener to improve interaction pe…
9c9e28c 
…rformance (#24360)

resolves #24359
This was referenced Jan 1, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-perkins sean-perkins sean-perkins approved these changes

@averyjohnston averyjohnston averyjohnston approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: content global click listener causing issues at scale
3 participants
@liamdebeasi @sean-perkins @averyjohnston