Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): fix content sometimes not loading due to race condition #24385

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

averyjohnston
Copy link
Contributor

@averyjohnston averyjohnston commented Dec 13, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: Resolves #24112

When datetime is used in a modal etc, there is a race condition between the datetime instance loading and the modal animation starting. This sometimes causes the intersectionObservers that handle the datetime-ready class to erroneously fire with a visibility of 0 from the beginning, so datetime-ready is never added.

What is the new behavior?

The observers that flag whether the datetime instance is ready now wait a frame before starting.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@averyjohnston averyjohnston requested a review from a team December 13, 2021 19:29
@github-actions github-actions bot added the package: core @ionic/core package label Dec 13, 2021
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: v6 datetime does not show if rapidly presented multiple times
3 participants