fix(datetime): fix content sometimes not loading due to race condition #24385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: Resolves #24112
When
datetime
is used in a modal etc, there is a race condition between thedatetime
instance loading and the modal animation starting. This sometimes causes theintersectionObserver
s that handle thedatetime-ready
class to erroneously fire with a visibility of 0 from the beginning, sodatetime-ready
is never added.What is the new behavior?
The observers that flag whether the
datetime
instance is ready now wait a frame before starting.Does this introduce a breaking change?
Other information