New travel_time_matrix() outputs #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although this probably wouldn't cause much problems to the majority of the users, hardcoding the path to point to .libPaths()[1] could lead to issues if r5r is not in this library. I, for instance, wanted to test the package without installing it, only loading via devtools, so the correct r5r's jar wasn't in that library, but inside the dev's inst/jar directory. Using system.file() fixes this issue.
…wn_stat` Updated package documentation
download_r5(): - changed example - changed option setting to follow download.file() recommendation - simplified code and adjusted formatting - started using check_connection() properly internal paths: - started using system.file() instead of .libPaths()[1]
now metadata is retrieved directly from the package repo, not downloaded from ipea's server. this lower the chances of dealing with frustrating timeouts and reduces r5r's internet dependency considerably. the package now only requires internet to download R5's most recent jar, and will skip this step if the jar has been already cached.
Added utility function to save data to CSV.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the new enhanced travel_time_matrix() function, discussed in issue #194.