Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use assert in remaining gateway tests #183

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Feb 23, 2023

Just use the assert library more thoroughly.

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #183 (c60aa9c) into main (7af2b2b) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head c60aa9c differs from pull request most recent head 7fca823. Consider uploading reports for the commit 7fca823 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   29.67%   29.57%   -0.11%     
==========================================
  Files         100      100              
  Lines       11258    11241      -17     
==========================================
- Hits         3341     3324      -17     
+ Misses       7550     7547       -3     
- Partials      367      370       +3     
Impacted Files Coverage Δ
gateway/handler.go 62.75% <0.00%> (-1.48%) ⬇️
gateway/handler_unixfs__redirects.go 38.79% <0.00%> (-0.55%) ⬇️
gateway/handler_tar.go 0.00% <0.00%> (ø)
gateway/handler_block.go 0.00% <0.00%> (ø)
gateway/handler_codec.go 0.00% <0.00%> (ø)
gateway/handler_unixfs_dir.go 65.10% <0.00%> (ø)
...tswap/client/internal/session/sessionwantsender.go 0.00% <0.00%> (ø)
files/multifilereader.go 82.02% <0.00%> (+0.20%) ⬆️
gateway/handler_unixfs.go 66.66% <0.00%> (+2.66%) ⬆️

@hacdias hacdias force-pushed the gateway/simplify-tests branch 3 times, most recently from 3026f6b to 6dc8bdb Compare March 6, 2023 10:13
@hacdias hacdias marked this pull request as ready for review March 6, 2023 10:54
@hacdias hacdias requested a review from lidel as a code owner March 6, 2023 10:54
@hacdias hacdias marked this pull request as draft March 6, 2023 10:55
@hacdias hacdias force-pushed the gateway/simplify-tests branch from 6dc8bdb to 7fca823 Compare March 6, 2023 11:05
@hacdias hacdias marked this pull request as ready for review March 6, 2023 11:14
@hacdias hacdias self-assigned this Mar 6, 2023
@hacdias hacdias changed the title refactor: simplify gateway tests refactor: use assert in remaining gateway tests Mar 6, 2023
@hacdias
Copy link
Member Author

hacdias commented Mar 6, 2023

I'm not exactly sure how the coverage decreased, and there is no coverage diff. It doesn't make sense to me since I did not change the tests themselves.

@lidel lidel merged commit 124ae4b into main Mar 14, 2023
@lidel lidel deleted the gateway/simplify-tests branch March 14, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants