Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: delete test-examples workflow #239

Merged
merged 1 commit into from
Mar 30, 2023
Merged

ci: delete test-examples workflow #239

merged 1 commit into from
Mar 30, 2023

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Mar 30, 2023

The test-examples workflow is obsolete because it duplicates the work performed by the Go Test workflow. This is because Go Test uses multiple-go-modules action to execute tests in all the submodules (see https://github.com/ipfs/boxo/blob/main/.github/workflows/go-test.yml#L44).

@galargh galargh requested review from guseggert and hacdias March 30, 2023 15:59
@galargh galargh requested a review from a team as a code owner March 30, 2023 15:59
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #239 (c2ce3ef) into main (6f324be) will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   47.70%   47.95%   +0.24%     
==========================================
  Files         266      269       +3     
  Lines       32950    32976      +26     
==========================================
+ Hits        15718    15812      +94     
+ Misses      15549    15496      -53     
+ Partials     1683     1668      -15     

see 17 files with indirect coverage changes

@hacdias hacdias merged commit 92407c6 into main Mar 30, 2023
@hacdias hacdias deleted the ci/delete-test-examples branch March 30, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants