Skip to content
This repository was archived by the owner on Feb 1, 2023. It is now read-only.

Queue Memory Leak #112

Closed
Stebalien opened this issue Apr 26, 2019 · 0 comments · Fixed by #116
Closed

Queue Memory Leak #112

Stebalien opened this issue Apr 26, 2019 · 0 comments · Fixed by #116
Assignees
@hannahhoward
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

As far as I can tell, we never actually remove peer request queues but let them build up over time. Obviously, this isn't good.
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Apr 26, 2019
hannahhoward added a commit that referenced this issue May 2, 2019
@hannahhoward
fix(decision): cleanup request queues
0a309a1 
Make sure when request queues are idle that they are removed

fix #112
@hannahhoward hannahhoward mentioned this issue May 2, 2019
Merged
@ghost ghost assigned hannahhoward May 2, 2019
@ghost ghost added the status/in-progress In progress label May 2, 2019
@ghost ghost removed the status/in-progress In progress label May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hannahhoward hannahhoward

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(decision): cleanup request queues ipfs/go-bitswap
2 participants
@Stebalien @hannahhoward