-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routing-v1 gateway endpoint not returning enough information #10195
Comments
2023-11-28 conversation: going to get this working in someguy first, then can port it over here to Kubo. |
Quick status update: If someone needs a pass-through that does no filtering, that is solved by https://github.com/ipfs-shipyard/someguy, which is deployed at $ curl -H "Accept: application/x-ndjson" https://delegated-ipfs.dev/routing/v1/providers/bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi -s | jq Due to this, this issue is now a lower priority, and there is no ETA when/if Kubo will do the same. I've opened #10337 with a proposal to close this and say filtering is a feature of Kubo. We can always revisit in the future. |
* docs: clarify Gateway.ExposeRoutingAPI Closes #10195 * Apply suggestions from code review Co-authored-by: Daniel Norman <1992255+2color@users.noreply.github.com> --------- Co-authored-by: Henrique Dias <mail@hacdias.com> Co-authored-by: Daniel Norman <1992255+2color@users.noreply.github.com>
Checklist
Installation method
ipfs-update or dist.ipfs.tech
Version
Config
No response
Description
When running against a node with
"ExposeRoutingAPI": true
and otherwise default routing I get less data than I can get by querying the underlying routing sources.Example:
However, when I query cid.contact (doesn't support streaming):
Note: Some peers like
QmUA9D3H7HeCYsirB3KmPSvZh3dNXMZas6Lwgr4fv1HTTp
and12D3KooWEkQFhSUc17MNC4gimbRYakSSCmDiQwMLhcvToh7bsXbN
are missing. These peers have return data like:Which seems to indicate that some less familiar schemas that might not be helpful to kubo itself (e.g. anything but
peer
andbitswap
) might be getting dropped. This is likely not what's intended when the API is used directly vs when it's been processed inside kubo for its use (i.e. internally kubo should of course drop the routing records it has no use for).Note: cid.contact may also have some bugs here in both emitting legacy record types and not handling metadata correctly.
The text was updated successfully, but these errors were encountered: