-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go-log to restore ndjson logging #5709
Comments
You mean that we should encode log like
instead of
? |
Yes. This has actually ben fixed (ipfs/go-log#53) we just need to pull the update through to go-ipfs. Unfortunately, doing so will drag along other changes in go-libp2p that we don't want to pull in before the release. We're now running the latest go-ipfs on one of our gateways to try to hammer out any bugs and we don't want to risk introducing new bugs by updating too much stuff. |
If you don't work for this now,maybe i can have a try. |
Really, all I need to do is run a single command and push a bunch of changes to a bunch of repos. It'll be much easier if I just do it (once we've cut a release). |
Ok,If anything else i can help , please ping me.Thx a lot |
@Stebalien can you try also pulling update for https://github.com/gxed/sha256-simd with this to fix an error in #5694 (WASM support)? |
Will do. |
fixes #5709 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
fixes #5709 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
fixes #5709 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
fixes #5709 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
fixes #5709 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
fixes #5709 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com> This commit was moved from ipfs/interface-go-ipfs-core@1c6351b This commit was moved from ipfs/boxo@93332aa
fixes #5709 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com> This commit was moved from ipfs/interface-go-ipfs-core@1c6351b This commit was moved from ipfs/boxo@93332aa
We changed go-log to spit out pretty json but we need to change it back as, apparently js-ipfs-api relies on it spitting out ndjson.
Unfortunately, as we're trying to cut a release, we didn't want to bubble the go-log change (pulls in every package). Therefore, we've just modified the
log tail
command to reformat the output. Once we've bubbled the go-log update, we need to remove the extra code in core/commands/log.go.The text was updated successfully, but these errors were encountered: