Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-log to restore ndjson logging #5709

Closed
Stebalien opened this issue Oct 31, 2018 · 7 comments · Fixed by #5726
Closed

Update go-log to restore ndjson logging #5709

Stebalien opened this issue Oct 31, 2018 · 7 comments · Fixed by #5726
Assignees
Labels
topic/technical debt Topic technical debt

Comments

@Stebalien
Copy link
Member

We changed go-log to spit out pretty json but we need to change it back as, apparently js-ipfs-api relies on it spitting out ndjson.

Unfortunately, as we're trying to cut a release, we didn't want to bubble the go-log change (pulls in every package). Therefore, we've just modified the log tail command to reformat the output. Once we've bubbled the go-log update, we need to remove the extra code in core/commands/log.go.

@Stebalien Stebalien added the topic/technical debt Topic technical debt label Oct 31, 2018
@kjzz
Copy link
Contributor

kjzz commented Oct 31, 2018

You mean that we should encode log like ndjson

{ "event": "Bitswap.Rebroadcast.idle", "session": "799c2a54-4bb2-4f9f-984c-c951b3dfb017", "system": "bitswap", "time": "2018-10-31T15:25:53.097215Z"}

instead of

{
  "event": "Bitswap.Rebroadcast.idle",
  "session": "799c2a54-4bb2-4f9f-984c-c951b3dfb017",
  "system": "bitswap",
  "time": "2018-10-31T15:25:53.097215Z"
}

?

@Stebalien
Copy link
Member Author

Yes. This has actually ben fixed (ipfs/go-log#53) we just need to pull the update through to go-ipfs. Unfortunately, doing so will drag along other changes in go-libp2p that we don't want to pull in before the release. We're now running the latest go-ipfs on one of our gateways to try to hammer out any bugs and we don't want to risk introducing new bugs by updating too much stuff.

@kjzz
Copy link
Contributor

kjzz commented Oct 31, 2018

If you don't work for this now,maybe i can have a try.

@Stebalien
Copy link
Member Author

Really, all I need to do is run a single command and push a bunch of changes to a bunch of repos. It'll be much easier if I just do it (once we've cut a release).

@kjzz
Copy link
Contributor

kjzz commented Nov 1, 2018

Ok,If anything else i can help , please ping me.Thx a lot

@magik6k
Copy link
Member

magik6k commented Nov 1, 2018

@Stebalien can you try also pulling update for https://github.com/gxed/sha256-simd with this to fix an error in #5694 (WASM support)?

@Stebalien
Copy link
Member Author

Will do.

Stebalien added a commit that referenced this issue Nov 3, 2018
fixes #5709

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost assigned Stebalien Nov 3, 2018
@ghost ghost added the status/in-progress In progress label Nov 3, 2018
Stebalien added a commit that referenced this issue Nov 3, 2018
fixes #5709

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Nov 3, 2018
fixes #5709

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Nov 3, 2018
fixes #5709

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Nov 3, 2018
fixes #5709

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost removed the status/in-progress In progress label Nov 5, 2018
hacdias pushed a commit that referenced this issue Nov 29, 2023
fixes #5709

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>


This commit was moved from ipfs/interface-go-ipfs-core@1c6351b

This commit was moved from ipfs/boxo@93332aa
hacdias pushed a commit that referenced this issue Nov 29, 2023
fixes #5709

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>


This commit was moved from ipfs/interface-go-ipfs-core@1c6351b

This commit was moved from ipfs/boxo@93332aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/technical debt Topic technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants