Gx updates and fixes to use new cid.Builder interface. #5375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org>
kevina
force-pushed
the
kevina/cid-builder
branch
from
7d8ee05 to
075ecb0
Compare
Stebalien
requested changes
Aug 13, 2018
core/coreunix/add.go
Outdated
| @@ -89,7 +89,7 @@ type Adder struct { | |||
| mroot *mfs.Root | |||
| unlocker bstore.Unlocker | |||
| tempRoot *cid.Cid | |||
| Prefix *cid.Prefix | |||
| Prefix cid.Builder | |||
There was a problem hiding this comment.
May want to call this CidBuilder.
There was a problem hiding this comment.
Okay. Fixed. I was doing this quick and planned to clean it up later.
mfs/ops.go
Outdated
| @@ -101,7 +101,7 @@ func PutNode(r *Root, path string, nd ipld.Node) error { | |||
| type MkdirOpts struct { | |||
| Mkparents bool | |||
| Flush bool | |||
| Prefix *cid.Prefix | |||
| Prefix cid.Builder | |||
There was a problem hiding this comment.
Same. Should probably rename this to CidBuilder.
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org>
|
Failed circleci test: Works for me locally. |
|
This should hopefully be good to go now... |
Stebalien
approved these changes
Aug 13, 2018
|
@schomatis has already signed off on the unixfs PR so I'll count that as the second sign off here (no additional design decisions). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Kevin Atkinson k@kevina.org