Build functioning dev packages for IREECompiler and IREERuntime. #16008
+593
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this patch, external projects can do: ``` find_package(IREECompiler) find_package(IREERuntime) ``` and access our targets by adding either the build or install tree `lib/cmake/IREE` to the CMake package search path. There are still some ergonomic issues that need to be addressed going forward: * cpuinfo breaks the one downstream I am testing this against. We really should just finish killing that, so I am setting -DIREE_ENABLE_CPUINFO=OFF in the dist package. * We are not yet re-establishing the pretty `iree::runtime:...` aliases. The underscore versions are available (`iree_runtime_...`). * I want to further isolate the remaining bundled deps (yaml and flatcc). * New convenience install targets do not have full dependency information. Need to do an `all` build first. As part of this, I did some longstanding cleanups: * Normalized the install component namespace. Defined `IREECMakeExports`, `IREEDevLibraries-Compiler`, `IREEDevLibraries-Runtime`, `IREERuntimeLibraries-Compiler`, `IREEBundledLibraries`, `IREETools-Runtime`. * Added convenience `iree-install-*` targets. Each includes a `-stripped` variant as well. * Moved MLIRInterop.h to the bindings/c directory where it should have been all along and straightened the deps. * Install the mlir-c headers to support libIREECompiler.so dev. * Added the "busybox" tool binaries to the install distribution (iree-lld, etc). * Stopped bundling upstream `lld` and `clang` by default because they bloat the size. `lld` is now bundled as `iree-lld` just like in the Python packages. Clang and llvm-link can be gotten by installing the new `IREETools-CompilerExtra` component if folks need those. Note that this only installs public headers and libraries needed to build against the compiler and runtime. Installing private things needed to develop parts of the system are out of scope.
stellaraccident
requested review from
ScottTodd,
benvanik and
pzread
as code owners
benvanik
reviewed
Dec 28, 2023
benvanik
approved these changes
Dec 28, 2023
rsuderman
approved these changes
Dec 28, 2023
stellaraccident
added a commit
to stellaraccident/onnxruntime
that referenced
this pull request
Dec 28, 2023
This is needed after iree-org/iree#16008 goes in.
stellaraccident
added a commit
to nod-ai/onnxruntime
that referenced
this pull request
Dec 29, 2023
This is needed after iree-org/iree#16008 goes in.
vinayakdsci
pushed a commit
to vinayakdsci/onnxruntime
that referenced
this pull request
Sep 10, 2024
This is needed after iree-org/iree#16008 goes in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch, external projects can do:
and access our targets by adding either the build or install tree
lib/cmake/IREEto the CMake package search path.There are still some ergonomic issues that need to be addressed going forward:
iree::runtime:...aliases. The underscore versions are available (iree_runtime_...).allbuild first.As part of this, I did some longstanding cleanups:
IREECMakeExports,IREEDevLibraries-Compiler,IREEDevLibraries-Runtime,IREERuntimeLibraries-Compiler,IREEBundledLibraries,IREETools-Runtime.iree-install-*targets. Each includes a-strippedvariant as well.lldandclangby default because they bloat the size.lldis now bundled asiree-lldjust like in the Python packages. Clang and llvm-link can be gotten by installing the newIREETools-CompilerExtracomponent if folks need those.Note that this only installs public headers and libraries needed to build against the compiler and runtime. Installing private things needed to develop parts of the system are out of scope.